Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds number of students along with percentages #57

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Conversation

Maybe14
Copy link
Member

@Maybe14 Maybe14 commented May 19, 2022

If you hover over a bar, it'll show you the amount of students

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
zotistics ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 3:16AM (UTC)

@Maybe14 Maybe14 linked an issue May 19, 2022 that may be closed by this pull request
@alexanderl19
Copy link
Member

Maybe instead of having a "raw numbers" switch we could have a toggle between percentage and student count?

Then, if a user adds more than one query, we would disable the student count option and default back to percentages?

Also, I think we should probably try to come up with a more intuitive name. I feel like raw numbers and student count are both kind of confusing.

@alexanderl19
Copy link
Member

alexanderl19 commented May 19, 2022

On second thought, we could also have a drop down list for chart "views". This list could then contain the change over time graph when it's implemented. #53

@alexanderl19 alexanderl19 added this to the Public Beta Launch milestone May 20, 2022
@alexanderl19 alexanderl19 marked this pull request as draft May 25, 2022 01:37
@Maybe14 Maybe14 changed the title Adds toggle to switch between percentages and raw numbers Adds number of students along with percentages May 30, 2022
@alexanderl19 alexanderl19 marked this pull request as ready for review February 28, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggle to switch between percentages and total students
2 participants