Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Scrape course history from WebReg EnrollHist #113

Closed
ecxyzzy opened this issue Nov 28, 2023 · 0 comments · Fixed by #135
Closed

Scrape course history from WebReg EnrollHist #113

ecxyzzy opened this issue Nov 28, 2023 · 0 comments · Fixed by #135
Assignees
Labels
area: api Related to the API in general story point: 3 Change to endpoint or response type: bug Something isn't working
Milestone

Comments

@ecxyzzy
Copy link
Member

ecxyzzy commented Nov 28, 2023

In the registrar scraper, the set of terms in which a course is offered is determined by taking all instructors that taught that course, and determining in which term(s) the instructors taught the course. This works for some courses, but it seems that instructors listed on the General Catalogue do not teach certain courses, and as such those courses do not have the correct set of terms. See icssc/peterportal-client#351 (comment).

Instead, we could consider using EnrollHist in addition to or in place of what we do currently.

@ecxyzzy ecxyzzy added story point: 3 Change to endpoint or response type: bug Something isn't working area: api Related to the API in general labels Nov 28, 2023
@cokwong cokwong self-assigned this Jan 27, 2024
@ecxyzzy ecxyzzy moved this to In Progress in PeterPortal API :: Next Jan 31, 2024
@ecxyzzy ecxyzzy added this to the 1.0 milestone Feb 29, 2024
@cokwong cokwong linked a pull request Feb 29, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in PeterPortal API :: Next Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: api Related to the API in general story point: 3 Change to endpoint or response type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants