Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user/guest icon in header #312

Closed
js0mmer opened this issue May 27, 2023 · 0 comments · Fixed by #421
Closed

Show user/guest icon in header #312

js0mmer opened this issue May 27, 2023 · 0 comments · Fixed by #421
Assignees
Labels
redesign Redesign UI Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the

Comments

@js0mmer
Copy link
Member

js0mmer commented May 27, 2023

Show the user icon in the collapsed sidebar so that the user can easily see whether or not they are logged in. Show a login button instead if the user is not logged in.

Another idea would be to put the user profile/log in button in the top right which is a more conventional place. Have a dropdown for it with the log out button and other profile tabs/settings (dark mode toggle & reviews to be added in future).

Here are some ideas I've mocked up.
image
image
image

For the mobile one, I borrowed some ideas from #239. Designs are not final and I'm still not sure what the mobile header would look like on other pages (without the course/professor toggle). I also moved the tabs to the bottom on the mobile design mock-up since I don't think a full screen expanding menu is needed for two tabs and this will make navigation quicker. I drew inspiration from YouTube and Twitter's mobile sites for this. Also when using the site as a guest, would probably still want a dropdown/toggle for changing the theme (once dark mode is complete).

@js0mmer js0mmer added Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always. redesign Redesign UI labels May 27, 2023
@js0mmer js0mmer moved this to Backlog in PeterPortal Client May 27, 2023
@js0mmer js0mmer added Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the and removed Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always. labels May 30, 2023
@js0mmer js0mmer self-assigned this Jul 22, 2023
@js0mmer js0mmer moved this from Backlog to In Progress in PeterPortal Client Oct 14, 2023
@js0mmer js0mmer changed the title Show user/guest icon in sidebar Show user/guest icon in header Nov 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in PeterPortal Client Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign Redesign UI Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the
Projects
Development

Successfully merging a pull request may close this issue.

1 participant