Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transfer courses now counted for prereqs in search #531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: transfer courses now counted for prereqs in search #531

wants to merge 4 commits into from

Conversation

timobraz
Copy link
Contributor

@timobraz timobraz commented Dec 7, 2024 •
edited
Loading

Description

The search hit component will validate completed transfer courses when accounting for prerequisite validation.

Steps to verify/test this change:

  • Check that transfer courses are considered in search results (no yellow outline and no showing missing prereqs)

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #513

@timobraz timobraz self-assigned this Dec 7, 2024
js0mmer
js0mmer approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js0mmer js0mmer js0mmer approved these changes

@charlieweinberger charlieweinberger Awaiting requested review from charlieweinberger

Assignees

@timobraz timobraz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer Prerequisites are not considered in course search
2 participants
@timobraz @js0mmer