Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the "Course Info" and "Prerequisite Not Met" Popovers #526

Open
Awesome-E opened this issue Dec 6, 2024 · 0 comments
Open

Merge the "Course Info" and "Prerequisite Not Met" Popovers #526

Awesome-E opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
frontend Front End tasks

Comments

@Awesome-E
Copy link
Member

There are currently two popovers inside Course.tsx: one with overlay={CoursePopover} and one with overlay={WarningPopover}.

These two should be combined into one component and be extracted into its own component file.

Instead of having the info circle and the warning icon, we should prefer the warning icon when prerequisites are not met, and use the info circle otherwise.

Here are the two popups this issue aims to combine:

Here's an example design of a roadmap quarter after this issue:

(you do not have to worry about changing/hiding course titles as that's not in scope of this issue)

Here's an example of what that merged popup could look like when you hover the info circle or warning icon:

@js0mmer js0mmer added the frontend Front End tasks label Dec 11, 2024
@CadenLee2 CadenLee2 self-assigned this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Front End tasks
Projects
Status: Backlog
Development

No branches or pull requests

3 participants