Tooltip and chart styling fixes #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome-E
requested changes
Dec 11, 2024
…eterportal-client into Grade-Dist-Styling-Fixes
Awesome-E
reviewed
Jan 6, 2025
| @@ -70,61 +70,46 @@ export default class Chart extends React.Component<ChartProps> { | |||
| id: 'A', | |||
| label: 'A', | |||
| A: gradeACount, | |||
| color: '#2484C6', | |||
There was a problem hiding this comment.
Missing colors[0]
Although ideally, we use a typescript enum to name the colors instead of just putting them in a list.
export enum GradeColors {
A = '#2484C6',
B = '#54B058',
// ...
}
// or Blue = '#2484C6', Green = '#54B058', ...color: GradeColors.A // or color: GradeColors.BlueThere was a problem hiding this comment.
same comment as previous about considering an enum instead of a hard-coded list
| @@ -72,7 +72,7 @@ const PrereqTreeNode: FC<TreeProps> = (props) => { | |||
| } | |||
| content={ | |||
| props.prerequisiteNames[ | |||
| prereq.prereqType === 'course' ? prereq.courseId.replace(/ /g, '') : (prereq.examName ?? '') | |||
| prereq.prereqType === 'course' ? prereq.courseId.replace(/ /g, '') : prereq.examName ?? '' | |||
There was a problem hiding this comment.
while this is correct, the precedence of ? : over ?? is not obvious to everyone, so I think this is a change that should be reverted
(unless that was a prettier auto-format)
There was a problem hiding this comment.
Looks like there's still a diff here since the newline at the end was deleted. We should add it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip and chart styling fixes
Description
Moved color constants and tooltip dimensions/styling to separate files and made dimensions the same.
Screenshots
Before
After
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #