Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Add TypeScript checks to actions #221

Open
3 tasks
ecxyzzy opened this issue Sep 12, 2022 · 1 comment
Open
3 tasks

Add TypeScript checks to actions #221

ecxyzzy opened this issue Sep 12, 2022 · 1 comment
Labels
devops deployment, testing, aws good first task Good for newcomers Story Point 1 Quick copy change

Comments

@ecxyzzy
Copy link
Member

ecxyzzy commented Sep 12, 2022

Currently our GitHub Actions tests don't include transpiling TypeScript to JavaScript, which is problematic because then no type checking is done on pull requests.

To make this happen, several minor things need to be done:

  • Remove "watch": true from tsconfig.json. This stops the TypeScript compiler from running in "watch mode," which would cause the automated tests to time out.
  • In the scripts object of package.json, add "build": "tsc".
  • In .github/workflows/tests.yml, add - run: npm run build after - run: npm test.
@ecxyzzy ecxyzzy added good first task Good for newcomers Story Point 1 Quick copy change devops deployment, testing, aws labels Sep 12, 2022
@ecxyzzy ecxyzzy moved this to Fellowship Tasks in PeterPortal API Sep 15, 2022
@vinnyho
Copy link

vinnyho commented Sep 21, 2024

I will take this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devops deployment, testing, aws good first task Good for newcomers Story Point 1 Quick copy change
Projects
Status: Fellowship Tasks
Development

No branches or pull requests

2 participants