Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages with prefix xcub #31

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

martinaxgloria
Copy link
Member

This PR includes several changes in the project to address:

Configuration file renaming:

  • Renamed all the packages with the xcub_ prefix and the related references in the project

Documentation updates:

  • Updated package names and paths in the README.md file to reflect the new naming conventions

Changes tested in simulations.

@traversaro
Copy link
Member

traversaro commented Nov 28, 2024

Thanks! Minor nitpick on the xcub_grasp and xcub_robot packages that are still pretty generic and do not describe a lot what the package is actually doing. Could it make sense to call them xcub_moveit_grasp and xcub_moveit_robot ?

Consider that the package name also induces the CMake package name used in find_package, and having the name find_package(xcub_grasp) or find_package(xcub_robot) for something that is not extremely generic may be confusing.

@martinaxgloria
Copy link
Member Author

Hi @traversaro, you're right. I renamed the last two packages as you suggested here d40c714

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@martinaxgloria martinaxgloria merged commit 0fdee7e into master Nov 28, 2024
1 check passed
@martinaxgloria martinaxgloria deleted the feat/rename_packs branch November 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions: use more specific package names?
3 participants