-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it still alive? Some advantages are needed. #7
Comments
Hi @tolezk, thanks for opening this issue!
|
I've made a PR (#8) to cover Now some thoughts about I think it should be similar to
Here we have:
To keep things playable in even a such case my proposal is to let a user define folder-level settings inside each folder, where required. And it still would keep backward compatibility with the current implementation. And would give the flexibility to achieve these goals. Some details. Several options ( |
I want you to confirm that proposal is ok to you and I will prepare the next PR to implement. Or we may have some discussion about. |
Anyway, I've implemented all the stuff. Now preparing a new PR. |
Hi, @idanpa and thank you for the extension!
So, long story short, I need this to have some additional features:
--showfile
option is passed to the checkpatchI'm not a person who familiar with js, ts or vscode-extensions creation. But I can provide a pull-request where I'll try to do my best to implement these features. It may violate typical codestyle or common sense for ts, though.
Now, some details.
The idea behind the first feature is to implement an alternative
parseCheckpatchLog()
function (or addition to it) which may handle a different output from checkpatch. For comparison:- this style of logs is supported for now.
- This style I want to be supported (here
--showfile
option was passed to checkpatch).About second feature. I think it would be good to define some option that a user can define inside
settings.json
of a particular workspace, and then extension should use this workspace as cwd, but not the root. I don't know if this possible or some other approach should be choosen. Of course this related to theCheckpatch Selected File
feature.I need some feedback for it from you,
Cheers.
The text was updated successfully, but these errors were encountered: