Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable simulations in the CI #253

Closed
3 tasks
saicharan0112 opened this issue Oct 18, 2023 · 4 comments
Closed
3 tasks

enable simulations in the CI #253

saicharan0112 opened this issue Oct 18, 2023 · 4 comments

Comments

@saicharan0112
Copy link
Collaborator

  • Update docker image msaligane/openfasoc to include ngspice
  • Pick config info for each generator and store the required output files for comparison
  • Build scripts to run the comparison after the run inside the workflow

@chetanyagoyal

@saicharan0112
Copy link
Collaborator Author

@chetanyagoyal please add the PR links beside the tasks - feel free to elaborate the tasks with sub-tasks if needed. Refer to PRs from Harsh and Ali - #211 etc. These are good practices.

@chetanyagoyal
Copy link
Collaborator

chetanyagoyal commented Nov 8, 2023

  • Update docker image msaligane/openfasoc to include ngspice (PR Add ngspice installation commands to the docker image #268)
  • Pick config info for each generator and store the required output files for comparison (PR Store simulation result file, return sim state from run #270)
    • Run prepex simulations for all operating temperatures
    • Store output files in subdirectory in .github/scripts
    • Propogate out the simulation state from python simulation scripts and store in the work directory
  • Enable sims in the CI (PR Enable sims in the CI #269)
    • Build scripts to run the comparison after the run inside the workflow
    • Edit temp-sensor yaml file to add simulation tests as a job
  • Clean up
  • Add script to check if generated file results are within some error percent of template file results
  • (Optional) Enhance the checks present in tests/common_api/test_simulation.py

@saicharan0112
Copy link
Collaborator Author

@chetanyagoyal please reuse the same workflow file for temp-sense to run the simulations. please avoid creating multiple workflows for a single generator

@chetanyagoyal
Copy link
Collaborator

@saicharan0112 please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants