Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BindingJS #404

Closed
wants to merge 3 commits into from
Closed

BindingJS #404

wants to merge 3 commits into from

Conversation

mfilip
Copy link
Member

@mfilip mfilip commented Jul 8, 2022

No description provided.

@mfilip mfilip requested a review from cblanc July 8, 2022 14:03
@mfilip mfilip changed the title [WIP] BindingJS BindingJS Aug 11, 2022
@mfilip mfilip linked an issue Aug 11, 2022 that may be closed by this pull request
Avoid loading binding.min.js in places other than Checkout #394
Open
@timpea
Copy link

timpea commented Mar 17, 2023

@mfilip @cblanc are you planning on merging this? I have not tested it.

@mfilip
Copy link
Member Author

mfilip commented Mar 20, 2023

@timpea this work in progress PR we do not plan to merge yet. Because we didn't test it against regex pattern to match for configuration patterns and problems that could arrive with that approach

@cblanc cblanc closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblanc cblanc Awaiting requested review from cblanc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid loading binding.min.js in places other than Checkout
3 participants
@mfilip @timpea @cblanc