Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version not generated correctly #25

Open
xiota opened this issue Aug 16, 2024 · 2 comments
Open

Version not generated correctly #25

xiota opened this issue Aug 16, 2024 · 2 comments

Comments

@xiota
Copy link
Contributor

xiota commented Aug 16, 2024

Describe the bug

Version string isn't generated correctly. 86ae0fe is affected.

$ xmap -V
xmap Development Build. Commit UNKNOWN

To Reproduce

  1. clone repo
  2. configure and build with cmake
  3. install and run xmap -V

Expected behavior

Commit hash should not be "UNKNOWN".

Desktop

  • OS: Arch Linux
  • Version: "UNKNOWN"

Additional context

Problem may be in src/CMakeVersion.txt

aur/xmap-git has been adjusted to produce output like following:

$ xmap -V
xmap AUR 2.0.2.r0.g86ae0fe
@idealeer
Copy link
Owner

good for me on Ubuntu 22.04:

$ git clone https://github.com/idealeer/xmap.git
$ cd xmap
$ cmake .
$ make -j4
$ make install
$ xmap -V
xmap Development Build. Commit 86ae0fe - Fri Aug 16 15:16:29 2024 +0800

image

please try again.

@xiota
Copy link
Contributor Author

xiota commented Aug 16, 2024

I think the problem is that I run out-of-tree builds.

$ cmake -S xmap -B  build -G Ninja
$ cmake --build build
$ build/src/xmap -V
xmap Development Build. Commit UNKNOWN

A workaround is to use:

GIT_DIR="$PWD/xmap" cmake --build build

As far as the AUR package is concerned, it has been revised to match the package (xmap AUR 2.0.2.r0.g86ae0fe).

On another topic, the GitHub Wiki mentioned in the readme isn't active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants