[ base ] Add casts between Int and ExitCode
#3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spcfox
force-pushed
the
cast-exit-code
branch
from
0a13d30 to
a314981
Compare
|
Thanks, this looks good |
andrevidela
pushed a commit
to andrevidela/Idris2
that referenced
this pull request
Dec 13, 2024
andrevidela
pushed a commit
to andrevidela/Idris2
that referenced
this pull request
Dec 17, 2024
andrevidela
pushed a commit
to andrevidela/Idris2
that referenced
this pull request
Dec 24, 2024
andrevidela
pushed a commit
to andrevidela/Idris2
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
systemreturnsInt, andexitWithtakesExitCode. So it is useful to have casts between the two. In particular this is needed for #3427, because most code generators usesystemforexecuteExpr.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).