From 830e2b832e58ec1d77814c0f5d35dce4574dd1d2 Mon Sep 17 00:00:00 2001
From: Sebastian <14994800+sebastian-peter@users.noreply.github.com>
Date: Sat, 17 Apr 2021 20:47:24 +0200
Subject: [PATCH] Fixed serialization related code smells

---
 .../input/system/characteristic/CharacteristicInput.java   | 6 +++---
 .../models/input/system/characteristic/CosPhiFixed.java    | 2 +-
 .../models/input/system/characteristic/CosPhiP.java        | 2 +-
 .../input/system/characteristic/EvCharacteristicInput.java | 2 +-
 .../system/characteristic/OlmCharacteristicInput.java      | 2 +-
 .../datamodel/models/input/system/characteristic/QV.java   | 2 +-
 .../system/characteristic/WecCharacteristicInput.java      | 2 +-
 .../edu/ie3/datamodel/models/timeseries/TimeSeries.java    | 6 +++---
 .../models/timeseries/repetitive/LoadProfileInput.java     | 7 +------
 .../datamodel/models/voltagelevels/CommonVoltageLevel.java | 2 +-
 10 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
index f41e0643a..5d2c953ae 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CharacteristicInput.java
@@ -23,7 +23,7 @@ public abstract class CharacteristicInput<A extends Quantity<A>, O extends Quant
   protected final String characteristicPrefix;
   protected final int decimalPlaces;
 
-  protected final SortedSet<CharacteristicPoint<A, O>> points;
+  private final SortedSet<CharacteristicPoint<A, O>> points;
 
   /**
    * Constructor for the abstract class
@@ -32,14 +32,14 @@ public abstract class CharacteristicInput<A extends Quantity<A>, O extends Quant
    * @param characteristicPrefix Prefix, that prepends the actual characteristic
    * @param decimalPlaces Desired amount of decimal places when de-serializing the characteristic
    */
-  public CharacteristicInput(
+  protected CharacteristicInput(
       SortedSet<CharacteristicPoint<A, O>> points, String characteristicPrefix, int decimalPlaces) {
     this.points = Collections.unmodifiableSortedSet(points);
     this.characteristicPrefix = characteristicPrefix;
     this.decimalPlaces = decimalPlaces;
   }
 
-  public CharacteristicInput(
+  protected CharacteristicInput(
       String input,
       Unit<A> abscissaUnit,
       Unit<O> ordinateUnit,
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiFixed.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiFixed.java
index c8e23a8cc..270b43539 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiFixed.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiFixed.java
@@ -52,6 +52,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "cosPhiFixed{" + "points=" + points + '}';
+    return "cosPhiFixed{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiP.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiP.java
index 987bd4b0b..b9fbed2c1 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiP.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/CosPhiP.java
@@ -39,6 +39,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "CosPhiP{" + "points=" + points + '}';
+    return "CosPhiP{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/EvCharacteristicInput.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/EvCharacteristicInput.java
index fe00c1e09..c1eeac9e8 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/EvCharacteristicInput.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/EvCharacteristicInput.java
@@ -41,6 +41,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "EvCharacteristicInput{" + "points=" + points + '}';
+    return "EvCharacteristicInput{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/OlmCharacteristicInput.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/OlmCharacteristicInput.java
index 77ac29f73..011d4ebc4 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/OlmCharacteristicInput.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/OlmCharacteristicInput.java
@@ -51,6 +51,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "OlmCharacteristicInput{" + "points=" + points + '}';
+    return "OlmCharacteristicInput{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/QV.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/QV.java
index 8f8eb4d94..5599cffed 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/QV.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/QV.java
@@ -38,6 +38,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "QV{" + "points=" + points + '}';
+    return "QV{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/WecCharacteristicInput.java b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/WecCharacteristicInput.java
index 0a531e4bc..131475c50 100644
--- a/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/WecCharacteristicInput.java
+++ b/src/main/java/edu/ie3/datamodel/models/input/system/characteristic/WecCharacteristicInput.java
@@ -34,6 +34,6 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return "WecCharacteristicInput{" + "points=" + points + '}';
+    return "WecCharacteristicInput{" + "points=" + getPoints() + '}';
   }
 }
diff --git a/src/main/java/edu/ie3/datamodel/models/timeseries/TimeSeries.java b/src/main/java/edu/ie3/datamodel/models/timeseries/TimeSeries.java
index 426011ae8..b5eb6125c 100644
--- a/src/main/java/edu/ie3/datamodel/models/timeseries/TimeSeries.java
+++ b/src/main/java/edu/ie3/datamodel/models/timeseries/TimeSeries.java
@@ -19,14 +19,14 @@
  */
 public abstract class TimeSeries<E extends TimeSeriesEntry<V>, V extends Value>
     extends UniqueEntity {
-  protected final Set<E> entries;
+  private final Set<E> entries;
 
-  public TimeSeries(Set<E> entries) {
+  protected TimeSeries(Set<E> entries) {
     super();
     this.entries = Collections.unmodifiableSet(entries);
   }
 
-  public TimeSeries(UUID uuid, Set<E> entries) {
+  protected TimeSeries(UUID uuid, Set<E> entries) {
     super(uuid);
     this.entries = Collections.unmodifiableSet(entries);
   }
diff --git a/src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileInput.java b/src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileInput.java
index f9cd3941f..8964a177a 100644
--- a/src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileInput.java
+++ b/src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileInput.java
@@ -23,7 +23,7 @@ public LoadProfileInput(UUID uuid, StandardLoadProfile type, Set<LoadProfileEntr
     super(uuid, values);
     this.type = type;
     this.dayOfWeekToHourlyValues =
-        entries.stream()
+        getEntries().stream()
             .collect(
                 Collectors.groupingBy(
                     LoadProfileEntry::getDayOfWeek,
@@ -54,11 +54,6 @@ public StandardLoadProfile getType() {
     return type;
   }
 
-  @Override
-  public Set<LoadProfileEntry> getEntries() {
-    return entries;
-  }
-
   @Override
   public boolean equals(Object o) {
     if (this == o) return true;
diff --git a/src/main/java/edu/ie3/datamodel/models/voltagelevels/CommonVoltageLevel.java b/src/main/java/edu/ie3/datamodel/models/voltagelevels/CommonVoltageLevel.java
index 7cb35b03c..d120a64ee 100644
--- a/src/main/java/edu/ie3/datamodel/models/voltagelevels/CommonVoltageLevel.java
+++ b/src/main/java/edu/ie3/datamodel/models/voltagelevels/CommonVoltageLevel.java
@@ -16,7 +16,7 @@
 
 /** Class with extended information to describe common voltage levels in energy systems. */
 public class CommonVoltageLevel extends VoltageLevel {
-  protected final Set<String> synonymousIds;
+  private final Set<String> synonymousIds;
   protected final RightOpenInterval<ComparableQuantity<ElectricPotential>> voltageRange;
 
   /**