Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with unit comparison of "equal units" #748

Closed
t-ober opened this issue Feb 14, 2023 · 1 comment
Closed

Problems with unit comparison of "equal units" #748

t-ober opened this issue Feb 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@t-ober
Copy link
Contributor

t-ober commented Feb 14, 2023

In 78c168d when comparing values of kind:

      actual.getgM() should equalWithTolerance(
        Quantities.getQuantity(826.44628, MetricPrefix.NANO(SIEMENS))
      )

We got failing tests, even though they shouldn't.

The problem of the test failing was the unit even though it was of unit nano Siemens.
Looking into the unit actual had a noted symbol attribute while expected didn't.
I suspect that it has something to do with the StandardUnits.

In any case this comparison should work. Find out what this is about

@t-ober t-ober added the bug Something isn't working label Feb 14, 2023
@t-ober
Copy link
Contributor Author

t-ober commented Feb 14, 2023

Moved to ie3-institute/simBench2psdm#138

@t-ober t-ober closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant