To/#181 reduced grid model #185
Conversation
|
!test |
src/main/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducer.scala
Outdated
Show resolved
Hide resolved
| ReactivePowerCharacteristic.parse( | ||
| s"cosPhiFixed:{(0.0, 0.95)}" | ||
| ), | ||
| 1.0.asKiloWatt, | ||
| 0.95 |
There was a problem hiding this comment.
You may consider adding those parameters to the method signature and assign default values. Once again, you would be more flexible in the way you can apply the method.
There was a problem hiding this comment.
I only create these system participants so I can overwrite their behavior with primary data so the parameters don't matter and I do not think that this comes in handy anywhere else.
There was a problem hiding this comment.
Okay, in that scenario it actually works. However, the model after that is then "implicitly" bound to only be used in conjunction with a primary data source.
I'm a bit worrying about other people coming accross the repository in some months or years and using the created models in a fashion, that is physically / simulation-wise not sensible. Maybay you can add a warning to the README.md then?
There was a problem hiding this comment.
I did add words of warnings to the method descriptions. Since the models don't ship with the code you shouldn't be able to use the models incorrectly and I think with the added comment it should be sufficiently clear.
There was a problem hiding this comment.
I did add words of warnings to the method descriptions. Since the models don't ship with the code you shouldn't be able to use the models incorrectly and I think with the added comment it should be sufficiently clear.
src/test/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducerSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/powerFactory2psdm/reduce/GridModelReducerSpec.scala
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 86.45% 83.91% -2.54%
==========================================
Files 40 41 +1
Lines 967 1032 +65
Branches 2 2
==========================================
+ Hits 836 866 +30
- Misses 131 166 +35
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Analysis Details1 Issue
Coverage and Duplications
Project ID: edu.ie3:powerFactory2psdm |
Resolves #181