Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use local files instead of download. #257

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add option to use local files instead of download. #257

wants to merge 13 commits into from

Conversation

staudtMarius
Copy link
Member

Resolves #256

@staudtMarius staudtMarius self-assigned this Aug 7, 2024
@staudtMarius staudtMarius marked this pull request as ready for review August 8, 2024 11:44
@staudtMarius staudtMarius requested a review from jo-bao August 8, 2024 11:44
@staudtMarius staudtMarius added the enhancement New feature or request label Aug 8, 2024
@jo-bao
Copy link
Contributor

jo-bao commented Aug 15, 2024

!test

jo-bao
jo-bao reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me at all! Just some remarks.
But @sebastian-peter has some other comments?

input/config/localFileSourceConfig.conf Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simbench/main/SimbenchHelper.scala Outdated Show resolved Hide resolved
@staudtMarius staudtMarius requested a review from jo-bao August 21, 2024 11:02
danielfeismann
danielfeismann requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a first view here, but I guess the merge conflicts need to be solved first

src/test/scala/edu/ie3/test/common/ConfigTestData.scala Show resolved Hide resolved
@staudtMarius
Merge branch 'main' into ms/#256-add-option-to-use-local-files-instea…
fa74112 
…d-of-download

# Conflicts:
#	build.gradle
#	src/main/resources/config-template.conf
#	src/main/scala/edu/ie3/simbench/config/SimbenchConfig.scala
#	src/main/scala/edu/ie3/simbench/main/RunSimbench.scala
@staudtMarius
Adapting code.
d9e1988
@staudtMarius
Un-ignore download tests.
b4aa6f0
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.48%. Comparing base (d689425) to head (bae1b2a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   62.75%   62.48%   -0.27%     
==========================================
  Files          70       70              
  Lines        2054     2090      +36     
  Branches       48       48              
==========================================
+ Hits         1289     1306      +17     
- Misses        765      784      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann requested changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

@jo-bao jo-bao Awaiting requested review from jo-bao

Requested changes must be addressed to merge this pull request.

Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to use local files instaed of downloading
3 participants
@staudtMarius @jo-bao @danielfeismann