Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA calls the wrong sonarqube quality gate link #1061

Closed
sebastian-peter opened this issue Dec 2, 2024 · 0 comments · Fixed by #1066
Closed

GHA calls the wrong sonarqube quality gate link #1061

sebastian-peter opened this issue Dec 2, 2024 · 0 comments · Fixed by #1066
Assignees
@PhilippSchmelter
Labels
ci Related to continuous integration

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Dec 2, 2024 •
edited
Loading

Currently calls https://simona.ie3.e-technik.tu-dortmund.de/sonar/api/qualitygates/project_status?projectKey=edu.ie3:simona, which belongs to the default branch (i.e. dev in our case).

If one attaches &pullRequest=<id> for PRs or &branch=<branch name> for branches, we get the proper results. Can be tested with PR #960, which is currently failing. I could image using the PR parameter for PRs would be preferable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippSchmelter PhilippSchmelter

Labels
ci Related to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using the right Link for Sonar ie3-institute/simona
2 participants
@sebastian-peter @PhilippSchmelter