Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix determineState of ThermalHouse #926

Closed
danielfeismann opened this issue Aug 24, 2024 · 1 comment · Fixed by #927
Closed

Fix determineState of ThermalHouse #926

danielfeismann opened this issue Aug 24, 2024 · 1 comment · Fixed by #927
Assignees
@danielfeismann
Labels
bug Something isn't working

Comments

@danielfeismann
Copy link
Member

When determining the state of ThermalHouse till the actual tick, the "old" ambientTemperature in the meaning temperature till the actual tick should be used. At the moment we use the ambientTemperature which can be updated within the actual tick.

This is neccessary for some issues described in #827
@danielfeismann danielfeismann self-assigned this Aug 24, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Aug 24, 2024
@danielfeismann danielfeismann mentioned this issue Aug 24, 2024
Merged
danielfeismann added a commit that referenced this issue Aug 24, 2024
@danielfeismann
Merge remote-tracking branch 'refs/remotes/origin/df/#926-Fix-determi…
baabf85 
…neState-of-ThermalHouse' into df/tmpHPmergeall
danielfeismann added a commit that referenced this issue Aug 28, 2024
@danielfeismann
Merge branch 'dev' into df/#926-Fix-determineState-of-ThermalHouse
11a559b
sebastian-peter added a commit that referenced this issue Aug 28, 2024
@sebastian-peter
Merge pull request #927 from ie3-institute/df/#926-Fix-determineState…
b870fe7 
…-of-ThermalHouse

Fix determineState of ThermalHouse
@danielfeismann
Copy link
Member Author

danielfeismann commented Aug 29, 2024 •
edited
Loading

This is solved as well #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix determineState of ThermalHouse ie3-institute/simona
1 participant
@danielfeismann