Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ThermalGrid.energyDemand #928

Closed
danielfeismann opened this issue Aug 24, 2024 · 0 comments · Fixed by #929
Closed

Refactor ThermalGrid.energyDemand #928

danielfeismann opened this issue Aug 24, 2024 · 0 comments · Fixed by #929
Labels
bug Something isn't working

Comments

@danielfeismann
Copy link
Member

Refactor ThermalGrid.energyDemand to deliver separated energyDemands of house and storage. This (partly) helps to tackle the following issues:

Sub-Issue to #827

Heatpump not under control of EmAgent

Point 4

House got overheated again -> 2019-01-18 14:00 (to be checked why)

Point 5

Hp runs longer than expected -> 2019-01-18 15:00 together with double and wrong storage result entries.

Point 10

qDot result still positive when storage is already full (2019-01-20 04:00), no exact entry when storage reaches full charge.

@danielfeismann danielfeismann added bug Something isn't working invalid Issue is not applicable labels Aug 24, 2024
danielfeismann added a commit that referenced this issue Aug 24, 2024
…ermalGird-energyDemand' into df/tmpHPmergeall
danielfeismann added a commit that referenced this issue Aug 26, 2024
danielfeismann added a commit that referenced this issue Sep 16, 2024
danielfeismann added a commit that referenced this issue Sep 17, 2024
danielfeismann added a commit that referenced this issue Sep 17, 2024
danielfeismann added a commit that referenced this issue Oct 1, 2024
danielfeismann added a commit that referenced this issue Oct 14, 2024
danielfeismann added a commit that referenced this issue Oct 15, 2024
danielfeismann added a commit that referenced this issue Oct 22, 2024
sebastian-peter added a commit that referenced this issue Oct 25, 2024
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
@sebastian-peter sebastian-peter removed the invalid Issue is not applicable label Oct 25, 2024
danielfeismann added a commit that referenced this issue Oct 28, 2024
danielfeismann added a commit that referenced this issue Nov 1, 2024
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
danielfeismann added a commit that referenced this issue Nov 7, 2024
danielfeismann added a commit that referenced this issue Nov 13, 2024
danielfeismann added a commit that referenced this issue Nov 14, 2024
…rgyDemand' into df/#928-Refactor-ThermalGird-energyDemand
danielfeismann added a commit that referenced this issue Nov 14, 2024
danielfeismann added a commit that referenced this issue Nov 14, 2024
sebastian-peter added a commit that referenced this issue Nov 14, 2024
…rd-energyDemand

Refactor thermal grid energy demand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants