Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use default app version in helm charts #445

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented Jan 14, 2024

No description provided.

@kesara kesara requested a review from NGPixel January 14, 2024 22:03
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f33cba) 97.03% compared to head (8494bd7) 97.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files          11       11           
  Lines         977      977           
=======================================
  Hits          948      948           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NGPixel
Copy link
Member

NGPixel commented Jan 14, 2024

Maybe put in comments rather than removing completely? The override is still good to know.

@kesara
Copy link
Member Author

kesara commented Jan 14, 2024

Maybe put in comments rather than removing completely? The override is still good to know.

Done.
I kept the example as well since the rest of that file has examples.

@kesara kesara merged commit 11e8d1a into ietf-tools:main Jan 14, 2024
5 checks passed
@kesara kesara deleted the ci/update-tag branch January 14, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants