-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft-ietf-tsvwg-ieee-802 should not be a thing #381
Comments
That'd be a good addition to the index code. |
Thank you for raising this issue @rjsparks . This issue is being investigated |
It turns out, ietf-tools/relaton-data-ids contains some data generated from older versions of a Relaton Gem (specifically I do not recall being there any particular reason for not removing old data. @kesara can you confirm? In case there is no reason, here is the PR here |
The document |
The datatracker has the advantage of knowing what drafts exist. When it makes bibxml-id entries it uses the draft name. When it tries to find drafts that are ambiguous because there are endings that might be versions or part of the draft name, it probes the set of known names as part of the heuristics. See https://github.com/ietf-tools/datatracker/blob/b78f5bab908dcd5e078cfcb947bc01b8a7a8f721/ietf/doc/utils.py#L1201-L1209. This works by looking for the longest matching string that is still an existing draftname. It relies on there not being any draft names in the database were A-nn and A are both valid names. If we ever allowed that to happen, the heuristics would become much more complicated. For the bibxml service, I would look to see if that at the point the code is generating the anchor it has fully identified the draft name already and is unconditionally stripping -nn when it shouldn't be. |
Thank you for the pointers to the Datatracker implementation @rjsparks . I'm looking into implementing a similar heuristic in the bibxml-service, however I am running into a loop of cases which are creating some confusion. To summarise, and I invite you to confirm the new behaviour of the service:
* these are paths that by default would raise an exception, because the expected format is either One last case that is not supported: Can you please confirm all of the above? Thanks |
Could you also please confirm the expected anchor values for the above cases? |
For the first checkbox, yes, but more importantly |
The other check boxes are on track, but the * is not. draft-sparks-sipcore-multiple-reasons-00 should definitely be something I can ask for. Can you clarify what you meant with the *? |
In case of such path the service looks up for a document having name |
The better way (because it's going to be right 99.99... for some string of 9s percent of the time) is to look for draft-sparks-sipcore-multiple-reasons first and if so, treat the -00 as a version. Only if you don't find a draft-sparks-sipcore-multiple-reasons would you go look for something named draft-sparks-sipcore-multiple-reasons-00. Doing it in the order you suggest will cause a database lookup that will fail all but that very fractional small percent. There are other ways to optimize this (that involve keeping extra configuration or state) but the above is the path the datatracker takes. |
Hi @rjsparks , I am not fully confident of submitting a PR just yet, as the changes I've made affect a big part of the Internet Draft adapter. However, I deployed what is in this PR to our dev instance (https://dev.bibxml.org) and I invite you to test the new changes. In particular, note that while before https://bib.ietf.org/get-one/by-docid/?docid=draft-ietf-tsvwg-ieee-802-11&doctype=Internet-Draft&query=draft-ietf-tsvwg-ieee-802&query_format=docid_regex&page=1 would point to https://bib.ietf.org/public/rfc/bibxml3/reference.I-D.ietf-tsvwg-ieee-802.xml , the dev instance (https://dev.bibxml.org/get-one/by-docid/?docid=draft-ietf-tsvwg-ieee-802-11&doctype=Internet-Draft&query=draft-ietf-tsvwg-ieee-802&query_format=docid_regex&page=1) now points to the right document (https://dev.bibxml.org/public/rfc/bibxml3/reference.I-D.draft-ietf-tsvwg-ieee-802-11.xml). The wrong URL (https://bib.ietf.org/public/rfc/bibxml-ids/reference.I-D.ietf-tsvwg-ieee-802.xml) can still be accessed manually tho, as I haven't found a way to block it without blocking other valid paths. Please note: the way this part of the system was implemented makes it very hard to accommodate this special case without breaking other paths. We may have to reconsider a different approach if the above proposed solution does not satisfy the requirements. |
@stefanomunarini - @kesara may have more to say after looking more closely, but I think that for the short term, getting the correct answer for a correct question is far more important than getting a wrong answer for the wrong question. These are rare enough that if the last example is problematic, we can block it or redirect it at cloudflare. |
Describe the issue
From a conversation with @stefanomunarini in #378:
draft-ietf-tsvwg-ieee-802
does not exist.draft-ietf-tsvwg-ieee-802-11
does (it became an RFC - its last version wasdraft-ietf-tsvwg-ieee-802-11-11
.The datatracker has some heuristics that use probing to see what exists when a name ends in
-\d\d
. I suspect the code that chose to indexietf-tsvwg-ieee-802
lacks similar consideration.Code of Conduct
The text was updated successfully, but these errors were encountered: