Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Datatracker lookup logic #460

Open
1 task done
kesara opened this issue Aug 14, 2024 · 1 comment
Open
1 task done

Improve Datatracker lookup logic #460

kesara opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kesara
Copy link
Member

kesara commented Aug 14, 2024

Describe the issue

This is related to #458

BibXML makes two queries to get I-D information.
First, https://datatracker.ietf.org/api/v1/doc/document/<draft name>/.
Secondly, https://datatracker.ietf.org/api/v1/submit/submission/<submission id>/.
submission id is the last submission in <submissions type="list"> from the first query.
THis submissions list can also include failed submissions and if the last submission is a failed submission, BibXML Service will fail to get I-D information.

With the following call, BibXML Service can only get successful submissions.

https://datatracker.ietf.org/api/v1/submit/submission/?format=json&draft__name=<draft name>&state_id=posted

This might also prevent BibXML Service from making two calls to DT.

Code of Conduct

@kesara kesara added the bug Something isn't working label Aug 14, 2024
@rjsparks
Copy link
Member

Note that not all Documents of type draft have associated Submission objects. (Very old drafts, in particular, will have no Submission data).

>>> Document.objects.filter(type="draft",submission__isnull=True).count()
15543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants