chore: release #32
Triggered via pull request
September 15, 2024 21:12
Status
Success
Total duration
5m 21s
Artifacts
–
Annotations
10 warnings
`impl (for<'a> Fn(insta::internals::Content, insta::internals::ContentPath<'a>) -> std::string::String) + std::clone::Clone + 'static` will capture more lifetimes than possibly intended in edition 2024:
crates/test_utils/src/lib.rs#L10
warning: `impl (for<'a> Fn(insta::internals::Content, insta::internals::ContentPath<'a>) -> std::string::String) + std::clone::Clone + 'static` will capture more lifetimes than possibly intended in edition 2024
--> crates/test_utils/src/lib.rs:10:6
|
10 | ) -> impl Fn(Content, ContentPath) -> String + Clone + 'static {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this changes meaning in Rust 2024
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/rpit-lifetime-capture.html>
note: specifically, this lifetime is in scope but not mentioned in the type's bounds
--> crates/test_utils/src/lib.rs:9:15
|
9 | replacement: &str,
| ^
= note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024
= note: `-W impl-trait-overcaptures` implied by `-W rust-2024-compatibility`
= help: to override `-W rust-2024-compatibility` add `#[allow(impl_trait_overcaptures)]`
|
`impl (for<'a> Fn(insta::internals::Content, insta::internals::ContentPath<'a>) -> std::string::String) + std::clone::Clone + 'static` will capture more lifetimes than possibly intended in edition 2024:
crates/test_utils/src/lib.rs#L28
warning: `impl (for<'a> Fn(insta::internals::Content, insta::internals::ContentPath<'a>) -> std::string::String) + std::clone::Clone + 'static` will capture more lifetimes than possibly intended in edition 2024
--> crates/test_utils/src/lib.rs:28:6
|
28 | ) -> impl Fn(Content, ContentPath) -> String + Clone + 'static {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: this changes meaning in Rust 2024
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/rpit-lifetime-capture.html>
note: specifically, this lifetime is in scope but not mentioned in the type's bounds
--> crates/test_utils/src/lib.rs:27:15
|
27 | replacement: &str,
| ^
= note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024
|
the `expr` fragment specifier will accept more expressions in the 2024 edition:
crates/wallet_standard/src/solana/sign_in.rs#L166
warning: the `expr` fragment specifier will accept more expressions in the 2024 edition
--> crates/wallet_standard/src/solana/sign_in.rs:166:11
|
166 | ($field:expr, $name:literal) => {
| ^^^^
|
= warning: this changes meaning in Rust 2024
= note: for more information, see Migration Guide <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/macro-fragment-specifiers.html>
= note: `-W edition-2024-expr-fragment-specifier` implied by `-W rust-2024-compatibility`
= help: to override `-W rust-2024-compatibility` add `#[allow(edition_2024_expr_fragment_specifier)]`
help: to keep the existing behavior, use the `expr_2021` fragment specifier
|
166 | ($field:expr_2021, $name:literal) => {
| ~~~~~~~~~
|
the `expr` fragment specifier will accept more expressions in the 2024 edition:
crates/wallet_standard/src/solana/sign_in.rs#L239
warning: the `expr` fragment specifier will accept more expressions in the 2024 edition
--> crates/wallet_standard/src/solana/sign_in.rs:239:11
|
239 | ($field:expr, $name:literal) => {
| ^^^^
|
= warning: this changes meaning in Rust 2024
= note: for more information, see Migration Guide <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/macro-fragment-specifiers.html>
help: to keep the existing behavior, use the `expr_2021` fragment specifier
|
239 | ($field:expr_2021, $name:literal) => {
| ~~~~~~~~~
|
unused import: `async_signer::*`:
crates/wallet_standard_browser/src/features/solana/mod.rs#L1
warning: unused import: `async_signer::*`
--> crates/wallet_standard_browser/src/features/solana/mod.rs:1:9
|
1 | pub use async_signer::*;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
the `expr` fragment specifier will accept more expressions in the 2024 edition:
crates/wallet_standard_browser/src/types.rs#L26
warning: the `expr` fragment specifier will accept more expressions in the 2024 edition
--> crates/wallet_standard_browser/src/types.rs:26:23
|
26 | ($ident:ident, $name:expr) => {
| ^^^^
|
= warning: this changes meaning in Rust 2024
= note: for more information, see Migration Guide <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/macro-fragment-specifiers.html>
= note: `-W edition-2024-expr-fragment-specifier` implied by `-W rust-2024-compatibility`
= help: to override `-W rust-2024-compatibility` add `#[allow(edition_2024_expr_fragment_specifier)]`
help: to keep the existing behavior, use the `expr_2021` fragment specifier
|
26 | ($ident:ident, $name:expr_2021) => {
| ~~~~~~~~~
|
item in documentation is missing backticks:
crates/wallet_standard_browser/readme.md#L1
warning: item in documentation is missing backticks
--> /home/runner/work/wasm_solana/wasm_solana/crates/wallet_standard_browser/readme.md:1:3
|
1 | # wallet_standard_browser
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
help: try
|
1 | # `wallet_standard_browser`
| ~~~~~~~~~~~~~~~~~~~~~~~~~
|
use of deprecated struct `solana_sdk::stake::config::Config`: Please use `solana_sdk::stake::state::warmup_cooldown_rate()` instead:
crates/wasm_client_solana/src/solana_config_program.rs#L11
warning: use of deprecated struct `solana_sdk::stake::config::Config`: Please use `solana_sdk::stake::state::warmup_cooldown_rate()` instead
--> crates/wasm_client_solana/src/solana_config_program.rs:11:32
|
11 | use solana_sdk::stake::config::Config as StakeConfig;
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
first doc comment paragraph is too long:
crates/wasm_client_solana/src/rpc_response.rs#L38
warning: first doc comment paragraph is too long
--> crates/wasm_client_solana/src/rpc_response.rs:38:1
|
38 | / /// Wrapper for rpc return types of methods that provide responses both with and
39 | | /// without context. Main purpose of this is to fix methods that lack context
40 | | /// information in their return type, without breaking backwards compatibility.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `-W clippy::too-long-first-doc-paragraph` implied by `-W clippy::style`
= help: to override `-W clippy::style` add `#[allow(clippy::too_long_first_doc_paragraph)]`
|
this argument is passed by value, but not consumed in the function body:
crates/wasm_client_solana/src/solana_account_decoder/parse_config.rs#L63
warning: this argument is passed by value, but not consumed in the function body
--> crates/wasm_client_solana/src/solana_account_decoder/parse_config.rs:63:44
|
63 | fn parse_config_data<T>(data: &[u8], keys: Vec<(Pubkey, bool)>) -> Option<UiConfig<T>>
| ^^^^^^^^^^^^^^^^^^^ help: consider changing the type to: `&[(Pubkey, bool)]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
|