-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera intrinsics / camera_info topic #15
Comments
If this is WIP, I will make the following observations and suggestions:
Can you give any hints as to what type of calibration information will eventually be exposed in the ROS interface? I don't know how to convert the intrinsic parameters to a camera_info topic, because the conversion from the three rotation angles to a rotation matrix is not known to me, and because I don't know the coefficients of the so-called "new camera matrix". |
@madsherlock -- sorry it's taken so long for us to acknowledge your feedback. You're correct in noticing we don't expose intrinsics from the camera currently. Thanks for taking the time to provide detailed thoughts. I've added this to our backlog for future scheduling and will take your feedback into account when designing the feature. |
I was just wondering if adding camera_info is a planned feature. Not having the camera info topic makes it so that this device not "plug and play" compatible with many standard ros systems thus making it much harder to work with. Are there any plans to add this feature in the near future? |
Hi @servos, |
There are many different ros tools and packages that assume the camera_info exists since having a image + camera_info is the standard camera driver API for ros. Things like http://wiki.ros.org/image_proc tools, the "Camera" visualization in RVIZ, http://wiki.ros.org/image_geometry, and many packages use the CameraSubscriber to get an image + its camera info. Many sensors get around the distortion model not being available by publishing already rectified image topics such that the distortion model becomes a no-op. The Realsense is a good example of this. |
Thanks, James. We will work on fitting to this standard in our next releases. |
Hi,
Is there, or will there be support for obtaining camera intrinsics using the ifm3d-ros driver?
If yes, are they only for the unrectified images?
Using "ifm3d schema --dump" I see the "INTR_CAL: 256" option.
I suppose the right place for camera intrinsics is the camera_info topic typically associated with image streams from cameras.
I suppose the straightforward way to implementing this is to use the INTR_CAL bit to receive the intrinsics once (just like the extrinsics), and then publishing the camera_info continuously along with the image data.
However, if the on-sensor image rectification is enabled, the intrinsic parameters are modified. For example, the distortion coefficients go towards zero.
When performing image rectification in OpenCV, I would obtain a new camera matrix with new parameters for the "rectified camera". These would depend on eg. my choice of how to crop the rectified image.
The text was updated successfully, but these errors were encountered: