-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible pointer dereference #7
Comments
Hej @Bbulatov, thank you very much for the details. What tools have you used? What is the use-case you have in mind? |
@graugans, |
I apologize, there was confusion, in the second point, of course, there is no double free, but also dereference after free. In src/xmlrpc_parse.c the xmlrpc_parse_call() function calls parseCallXml() on 308, which frees the memory of the callElemP variable, but then callElemPP is assigned the value of callElemP, which has already been cleared. |
Okay, we primarily forked this repository for the sake of the CMake integration, because the original author has not supported CMake. We only use the client part so I do not see much benefit in fixing the server part which is number 3 in your list. It looks like you are already deep into this, could you please create a pull request to solve this? |
The developer agreed with point 3 and made the following commit: https://sourceforge.net/p/xmlrpc-c/code/3241/ |
Good day!
During the static analysis, it was revealed that in some places in the code situations arise that lead to various errors:
Does this require change? Could this lead to something critical?
The text was updated successfully, but these errors were encountered: