fix: fix chain id for chain simulations (#4309)

* fix chain id for simulations

* add changelog

changelog.md

@@ -43,6 +43,7 @@
 - [#4000](https://github.com/ignite/cli/pull/4000) Run all dry runners before the wet run in the `xgenny` pkg
 - [#4091](https://github.com/ignite/cli/pull/4091) Fix race conditions in the plugin logic
 - [#4128](https://github.com/ignite/cli/pull/4128) Check for duplicate proto fields in config
+- [#4309](https://github.com/ignite/cli/pull/4309) Fix chain id for chain simulations
 
 ## [`v28.5.1`](https://github.com/ignite/cli/releases/tag/v28.5.1)
 

ignite/templates/app/files/app/sim_test.go.plush

@@ -333,6 +333,7 @@ func TestAppStateDeterminism(t *testing.T) {
 	config.ExportParamsPath = ""
 	config.OnOperation = true
 	config.AllInvariants = true
+	config.ChainID = SimAppChainID
 
 	numSeeds := 3
 	numTimesToRunPerSeed := 3 // This used to be set to 5, but we've temporarily reduced it to 3 for the sake of faster CI.
@@ -372,8 +373,6 @@ func TestAppStateDeterminism(t *testing.T) {
 			} else {
 				logger = log.NewNopLogger()
 			}
-			chainID := fmt.Sprintf("chain-id-%d-%d", i, j)
-			config.ChainID = chainID
 
 			db := dbm.NewMemDB()
 			bApp, err := app.New(
@@ -383,7 +382,7 @@ func TestAppStateDeterminism(t *testing.T) {
 				true,
 				appOptions,
 				interBlockCacheOpt(),
-				baseapp.SetChainID(chainID),
+				baseapp.SetChainID(SimAppChainID),
 			)
             require.NoError(t, err)