Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if we can remove the time.Sleep to wait the plugin load #4101

Closed
Pantani opened this issue Apr 24, 2024 · 0 comments · Fixed by #4179
Closed

fix: check if we can remove the time.Sleep to wait the plugin load #4101

Pantani opened this issue Apr 24, 2024 · 0 comments · Fixed by #4179
Assignees
@Pantani
Labels
component:extensions Related to Ignite Extensions. type:enh Improvement or update to existing feature(s).

Comments

@Pantani
Copy link
Collaborator

Pantani commented Apr 24, 2024 

          It seems that adding the `KillClient` call might make the `time.Sleep` call redundant 🤔, so it might be possible to remove the `time.Sleep`. Killing the client should try to stop it gracefully, so buffers should be flushed properly if the plugin client is running without issues.

Maybe you could add a TODO? If it can't be properly tested to be sure in fact the time.Sleep is redundant now.

Originally posted by @jeronimoalbi in #4091 (comment)
@Pantani Pantani mentioned this issue Apr 24, 2024
Merged
@salmad3 salmad3 moved this from To Discuss to Todo in Ignite CLI Masterboard May 29, 2024
@salmad3 salmad3 added component:extensions Related to Ignite Extensions. type:enh Improvement or update to existing feature(s). labels May 29, 2024
@Pantani Pantani mentioned this issue Jun 4, 2024
Merged
@mergify mergify bot closed this as completed in #4179 Jun 5, 2024
mergify bot pushed a commit that referenced this issue Jun 5, 2024
@Pantani
fix: remove unused sleep for plugin execution (#4179)
24770f1 
close #4101
@github-project-automation github-project-automation bot moved this from Todo to Done in Ignite CLI Masterboard Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pantani Pantani

Labels
component:extensions Related to Ignite Extensions. type:enh Improvement or update to existing feature(s).
Projects
Ignite CLI Masterboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unused sleep for plugin execution ignite/cli
2 participants
@Pantani @salmad3