feat: availableport enhancements #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfant
changed the title
availableport enhancementsavailableport enhancements
github-actions
bot
added
component:ci
gfant
changed the title
availableport enhancements
Pantani
requested changes
Aug 9, 2023
|
can you please also add a changelog? |
|
@iam-agf any update on this PR? |
|
Sorry for the super slow update. Many things happening, but I think now is ready! |
Pantani
reviewed
Sep 18, 2023
|
@iam-agf any updates? can you use the table tests in the test? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
+ Coverage 24.99% 25.11% +0.12%
==========================================
Files 286 287 +1
Lines 23489 23539 +50
==========================================
+ Hits 5871 5912 +41
- Misses 17090 17096 +6
- Partials 528 531 +3
|
Pantani
requested changes
Oct 13, 2023
Pantani
previously approved these changes
Oct 13, 2023
jeronimoalbi
previously approved these changes
Oct 13, 2023
Sorry for the late response. An apologize. I'll try to make it faster and correct next time. |
No worries! Thank you for the contribution 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
availableport.Findonly allows the user to ask for ports between44000and55000and there is no verification about if the ports returned are the same.With this pull request is fixed the last part and now the users can add through a struct different ranges of ports and a custom randomizer.
Also I added the tests for the editions made.