Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move default plugin definitions to services plugin package #3650

Closed
wants to merge 13 commits into from

Conversation

jeronimoalbi
Copy link
Member

No description provided.

@jeronimoalbi jeronimoalbi added the component:extensions Related to Ignite Extensions. label Sep 8, 2023
@jeronimoalbi jeronimoalbi self-assigned this Sep 8, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. type:internal labels Sep 8, 2023
@jeronimoalbi
Copy link
Member Author

As discussed we want to list the default Ignite Apps in a Markdown file to be able to change the default Ignite Apps installed by the CLI only by changing the Markdown file.

This PR implements the feature if we decide to move forward with it.

Adding or removing apps would require to change the TestGetDefaultPlugins test that checks for the number of default apps on purpose.

ignite_apps.md Outdated Show resolved Hide resolved
@jeronimoalbi jeronimoalbi marked this pull request as ready for review September 8, 2023 14:07
go.mod Outdated Show resolved Hide resolved
@jeronimoalbi jeronimoalbi marked this pull request as draft September 25, 2023 12:16
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3650 (f0ec0be) into main (be5deaf) will increase coverage by 0.02%.
The diff coverage is 76.47%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3650      +/-   ##
==========================================
+ Coverage   24.90%   24.92%   +0.02%     
==========================================
  Files         287      288       +1     
  Lines       23221    23229       +8     
==========================================
+ Hits         5783     5790       +7     
- Misses      16925    16926       +1     
  Partials      513      513              
Files Coverage Δ
ignite/cmd/plugin.go 28.13% <ø> (ø)
ignite/services/plugin/default.go 87.50% <87.50%> (ø)
ignite/cmd/plugin_default.go 24.52% <66.66%> (ø)

@jeronimoalbi jeronimoalbi changed the title feat: support changing default Ignite Apps from Markdown file refactor: move default plugin definitions to services plugin package Sep 25, 2023
@jeronimoalbi jeronimoalbi added the skip-changelog Don't check changelog for new entries label Sep 25, 2023
@Ehsan-saradar
Copy link
Contributor

Hey @jeronimoalbi i was wondering if this is still WIP.

@jeronimoalbi
Copy link
Member Author

Hey @jeronimoalbi i was wondering if this is still WIP.

It's finished, just got to resolve the conflicts.

It started as a change to get default plugins from a markdown file, but after discussions it didn't make sense to be implemented so the current changes just reorganize the way default plugins are defined.

@Ehsan-saradar why do you ask? Do you need these changes merged?

@jeronimoalbi
Copy link
Member Author

The PR is not relevant anymore

@jeronimoalbi jeronimoalbi deleted the feat/ignite-apps-markdown branch December 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:extensions Related to Ignite Extensions. skip-changelog Don't check changelog for new entries type:internal type:refactor type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants