-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move default plugin definitions to services plugin
package
#3650
Conversation
As discussed we want to list the default Ignite Apps in a Markdown file to be able to change the default Ignite Apps installed by the CLI only by changing the Markdown file. This PR implements the feature if we decide to move forward with it. Adding or removing apps would require to change the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3650 +/- ##
==========================================
+ Coverage 24.90% 24.92% +0.02%
==========================================
Files 287 288 +1
Lines 23221 23229 +8
==========================================
+ Hits 5783 5790 +7
- Misses 16925 16926 +1
Partials 513 513
|
plugin
package
Hey @jeronimoalbi i was wondering if this is still WIP. |
It's finished, just got to resolve the conflicts. It started as a change to get default plugins from a markdown file, but after discussions it didn't make sense to be implemented so the current changes just reorganize the way default plugins are defined. @Ehsan-saradar why do you ask? Do you need these changes merged? |
The PR is not relevant anymore |
No description provided.