Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable Go toolchain download #3656

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

jeronimoalbi
Copy link
Member

We must disable toolchain download to allow go mod tidy to work. We are disabling GOMODSUM because of timeouts triggered because of the size of the CLI repo. Disabling GOMODSUM makes toolchain download fail. See: https://go.dev/doc/toolchain#download

We must disable toolchain download to allow `go mod tidy` to work.
We are disabling GOMODSUM because of timeouts triggered because of the
size of the CLI repo. Disabling GOMODSUM makes toolchain download fail.
See: https://go.dev/doc/toolchain#download
@jeronimoalbi jeronimoalbi added the type:bug Something isn't working label Sep 13, 2023
@jeronimoalbi jeronimoalbi self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #3656 (e0d4102) into main (4a226ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3656   +/-   ##
=======================================
  Coverage   24.89%   24.89%           
=======================================
  Files         287      287           
  Lines       23217    23219    +2     
=======================================
+ Hits         5779     5781    +2     
  Misses      16925    16925           
  Partials      513      513           
Files Changed Coverage Δ
ignite/pkg/gocmd/gocmd.go 29.47% <100.00%> (+1.51%) ⬆️

@jeronimoalbi jeronimoalbi merged commit 3832fa0 into main Sep 18, 2023
26 checks passed
@jeronimoalbi jeronimoalbi deleted the chore/disable-gotoolchain-download branch September 18, 2023 15:03
InnerPeace080 pushed a commit to titantkx/ignite-cli that referenced this pull request May 3, 2024
* chore: disable Go toolchain download

We must disable toolchain download to allow `go mod tidy` to work.
We are disabling GOMODSUM because of timeouts triggered because of the
size of the CLI repo. Disabling GOMODSUM makes toolchain download fail.
See: https://go.dev/doc/toolchain#download

* chore: update changelog

(cherry picked from commit 3832fa0)
devbv pushed a commit to settlus/cli that referenced this pull request Aug 12, 2024
* chore: disable Go toolchain download

We must disable toolchain download to allow `go mod tidy` to work.
We are disabling GOMODSUM because of timeouts triggered because of the
size of the CLI repo. Disabling GOMODSUM makes toolchain download fail.
See: https://go.dev/doc/toolchain#download

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants