-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): remove duplicate SetCmdClientContextHandler #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islishude
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
April 27, 2024 03:42
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:templates
component:configs
labels
Apr 27, 2024
Pantani
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
salmad3
approved these changes
Apr 29, 2024
@Mergifyio backport release/v28.x.y |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2024
there are two `client.SetCmdClientContextHandler(clientCtx, cmd)` (cherry picked from commit a2903dc)
julienrbrt
added a commit
that referenced
this pull request
May 6, 2024
…4112) (#4116) * fix(templates): remove duplicate SetCmdClientContextHandler (#4112) there are two `client.SetCmdClientContextHandler(clientCtx, cmd)` (cherry picked from commit a2903dc) * Update changelog.md --------- Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
there are two `client.SetCmdClientContextHandler(clientCtx, cmd)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two
client.SetCmdClientContextHandler(clientCtx, cmd)