Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: version scaffolded protos #4118

Merged
merged 5 commits into from
May 13, 2024
Merged

refactor!: version scaffolded protos #4118

merged 5 commits into from
May 13, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 5, 2024 •
edited
Loading

Closes: #3862

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs type:services Service-related issues. labels May 5, 2024
Pantani
Pantani previously approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

utACK

@julienrbrt julienrbrt requested a review from Pantani May 8, 2024 20:40
@julienrbrt julienrbrt marked this pull request as draft May 9, 2024 11:39
@julienrbrt julienrbrt marked this pull request as ready for review May 9, 2024 22:04
@julienrbrt julienrbrt mentioned this pull request May 9, 2024
Merged
@julienrbrt
Copy link
Member Author

#4128 should be merged before

Pantani
Pantani approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@julienrbrt julienrbrt merged commit 711cac2 into main May 13, 2024
45 of 46 checks passed
@julienrbrt julienrbrt deleted the julien/proto-ver branch May 13, 2024 21:33
julienrbrt added a commit that referenced this pull request May 29, 2024
@julienrbrt
refactor!: version scaffolded protos (#4118)
a43b3d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version module proto folder like Cosmos SDK modules
2 participants
@julienrbrt @Pantani