OF-2892 Available Plugins page: redesign to make Documentation easier to see #2541
Conversation
stokito
force-pushed
the
OF-1823_plugins
branch
2 times, most recently
from
3b217ed to
5917a86
Compare
stokito
changed the title
| String releaseDate = null; | ||
| final String releaseDateString = plugin.attributeValue("releaseDate"); | ||
| if( releaseDateString!= null) { | ||
| try { | ||
| releaseDate = RELEASE_DATE_DISPLAY_FORMAT.format(RELEASE_DATE_FORMAT.parse(releaseDateString)); | ||
| } catch (final ParseException e) { | ||
| Log.warn("Unexpected exception parsing release date: " + releaseDateString, e); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this exists because there are some older plugins out there with non-ISO release dates
There was a problem hiding this comment.
yes, I forgot to comment on this. We don't try to parse the date and just show it in UI. So its format doesn't affect anything.
There was a problem hiding this comment.
I anyway will recheck plugins. I remember that for the Pade plugin I already sent a PR
|
I've not tested this (yet) but this looks to be an awesome change! |
|
I've run this on top of main. Dates render, docs and changelog links work. There's one rendering bug when installing a plugin. Before: After: The columns all narrow to display the ✔️ for a few seconds, then returns to the before state. |
…ame instead of plugin.available.open_source And remove the unused open_source key
Fishbowler
force-pushed
the
OF-1823_plugins
branch
from
5917a86 to
dfe92df
Compare
|
Pushed the rebase. |
The Plugins and Available plugins pages have two icons for documentation (README) and changelog.
The icons are very small and placed together that makes it difficult to understand them.
The icons are only 16px and the only way to understand is to put a cursor over them to see a title. This wouldn't be possible to to from a mobile at all (minor issue).
As a solution we can switch to a table where each cell can have a few lines.
I moved the changelog icon into the Version column as a an additional row. The re
Similarly the Documentation link moved into the Description column, and the Description merged into the Plugin Name.