Use Handler.Sequence in place of ContextHandlerCollection #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he more specific org.eclipse.jetty.server.handler.ContextHandler implementation. According to the [Migration Guide](https://jetty.org/docs/jetty/12/programming-guide/migration/11-to-12.html#api-changes-handler-sequence), Handler.Sequence replaced HandlerCollection and HandlerList. ContextHandlerCollection is retained for its efficient child ContextHandler selection. Unless performance considerations or the need for a more restrictive implementation justify it, a more generic implementation reduces code complexity and provides greater functional possibilities for plugins.
hqv126
changed the title
guusdk
added a commit
to guusdk/Openfire
that referenced
this pull request
Nov 19, 2024
…he more specific org.eclipse.jetty.server.handler.ContextHandler implementation. According to the [Migration Guide](https://jetty.org/docs/jetty/12/programming-guide/migration/11-to-12.html#api-changes-handler-sequence), Handler.Sequence replaced HandlerCollection and HandlerList. ContextHandlerCollection is retained for its efficient child ContextHandler selection. Unless performance considerations or the need for a more restrictive implementation justify it, a more generic implementation reduces code complexity and provides greater functional possibilities for plugins. (igniterealtime#2609) Co-authored-by: “Huy <[email protected]> Co-authored-by: Guus der Kinderen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the more generic org.eclipse.jetty.server.Handler in place of the more specific org.eclipse.jetty.server.handler.ContextHandler implementation. According to the Migration Guide, Handler.Sequence replaced HandlerCollection and HandlerList. ContextHandlerCollection is retained for its efficient child ContextHandler selection. Unless performance considerations or the need for a more restrictive implementation justify it, a more generic implementation reduces code complexity and provides greater functional possibilities for plugins.