Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line calendar #109

Closed
igors48 opened this issue Jun 26, 2022 · 3 comments
Closed

line calendar #109

igors48 opened this issue Jun 26, 2022 · 3 comments

Comments

@igors48
Copy link
Owner

igors48 commented Jun 26, 2022 •
edited
Loading 

0109-line-calendar
#109 line calendar
igors48 added a commit that referenced this issue Jun 26, 2022
@igors48
#109 line calendar
7ef3c6f 
initial
igors48 added a commit that referenced this issue Jun 26, 2022
@igors48
#109 line calendar
5124fad 
initial
@igors48 igors48 pinned this issue Jun 26, 2022
igors48 added a commit that referenced this issue Jun 27, 2022
@igors48
#109 line calendar
3b4ac30 
cleanup
igors48 added a commit that referenced this issue Jun 28, 2022
@igors48
#109 line calendar
7458c2b 
todo
@igors48
Copy link
Owner Author

igors48 commented Jun 28, 2022 •
edited
Loading

file doxygen todos doc
src/apps/clock/clockAppTile.cpp ➖ ➖ ➖
src/apps/clock/lineCalendar.cpp ➖ ✔️ ➖
src/apps/clock/lineCalendar.hpp ➖ ✔️ ➖
src/core/watch/rtc.cpp ✔️ ➖ ➖
src/core/watch/rtc.hpp ✔️ ➖ ➖

@igors48
Copy link
Owner Author

igors48 commented Jun 28, 2022 •
edited
Loading

file todo issue code ref
src/apps/clock/lineCalendar.cpp static bool isStateModified(Component *component) // todo create dummies for isStateModified & updateState & render #132 ✔️
src/apps/clock/lineCalendar.cpp // todo create default factory for Component #133 ✔️
src/apps/clock/lineCalendar.hpp typedef void (*ProvideContext)(LineCalendarContext *state); // todo generic state provider function definition #134 ✔️

@igors48 igors48 mentioned this issue Jun 28, 2022
Closed
igors48 added a commit that referenced this issue Jun 28, 2022
@igors48
#109 line calendar
0a8fb7c 
close #111
doxygen
rtc refactor
igors48 added a commit that referenced this issue Jun 29, 2022
@igors48
#109 line calendar
4eea4c3 
todos
@igors48
Copy link
Owner Author

igors48 commented Jun 29, 2022 •
edited
Loading

if a branch will be just closed or will be merged

  • verify no uncommitted changes
  • verify that all the needed tests are created (if the branch will be merged)
  • verify that all the tests run by RUN_TEST (if the branch will be merged)
  • verify that all the tests passed (if the branch will be merged)
  • review issue notes, add them as the last comment
  • review all commits notes, add them as the last comment
  • review todos (if the branch will be just closed), add them as the last comment
  • update the used sources

if the branch will be merged

  • update the documentation (checking the diff between develop and feature branches)
  • create missing or update existing doxygen
  • clean up #includes
  • verify no uncommitted changes
  • switch to develop
  • sync local develop with origin
  • merge feature branch to develop
  • build project for watch env
  • run tests
  • sync local develop with origin
  • verify that commits appear in develop origin

if a branch will be just closed or will be merged

  • delete the local feature branch
  • delete the remote feature branch here
  • review todos, create follow up issue(s)
  • review the last comment, create follow up issue(s), add links to the issues to comment and code as well
  • close the related branch issue

@igors48 igors48 closed this as completed Jun 29, 2022
@igors48 igors48 unpinned this issue Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igors48