From 2dc2560c3379f0075a788e541cb6b7fe93ab74a2 Mon Sep 17 00:00:00 2001 From: Fred Hornsey Date: Wed, 28 Feb 2024 22:30:48 -0600 Subject: [PATCH] Add News and Remove Debug Print --- docs/news.d/cmake-cxx-std.rst | 2 +- docs/news.d/cmake-include-base.rst | 7 +++++++ tests/cmake/idl_compiler_tests/CMakeLists.txt | 1 - 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 docs/news.d/cmake-include-base.rst diff --git a/docs/news.d/cmake-cxx-std.rst b/docs/news.d/cmake-cxx-std.rst index b9dccb40744..378d78eb551 100644 --- a/docs/news.d/cmake-cxx-std.rst +++ b/docs/news.d/cmake-cxx-std.rst @@ -1,6 +1,6 @@ .. news-prs: 4481 -.. news-start-section: Fixes +.. news-start-section: Platform Support and Dependencies .. news-start-section: Building with CMake - Fixed :ghissue:`building with CMake and Apple Clang on macOS <4478>` without setting ``-DCMAKE_CXX_STANDARD=14`` or using ACE 6 by setting :cmake:var:`OPENDDS_CXX_STD` when ACE 7 is used. .. news-end-section diff --git a/docs/news.d/cmake-include-base.rst b/docs/news.d/cmake-include-base.rst new file mode 100644 index 00000000000..3f6d903ea5e --- /dev/null +++ b/docs/news.d/cmake-include-base.rst @@ -0,0 +1,7 @@ +.. news-prs: 4489 + +.. news-start-section: Fixes +.. news-start-section: CMake Config Package +- Made :cmake:func:`opendds_target_sources(INCLUDE_BASE)` work correctly in more cases, specifically involving generating an export header. +.. news-end-section +.. news-end-section diff --git a/tests/cmake/idl_compiler_tests/CMakeLists.txt b/tests/cmake/idl_compiler_tests/CMakeLists.txt index dee4512cf39..77ff3d1be6b 100644 --- a/tests/cmake/idl_compiler_tests/CMakeLists.txt +++ b/tests/cmake/idl_compiler_tests/CMakeLists.txt @@ -104,7 +104,6 @@ function(assert_generated_output file) set(expect_prefix_path "${expect_dir_path}/${filename_no_ext}") foreach(var failed dir_path file_path prefix_path) set(val "${${var}}") - # message("${var} ${val}") set(expect "${expect_${var}}") if(NOT val STREQUAL expect) message(SEND_ERROR