From 8ecb35c333cc339a13ad3e745b4ced743f383c75 Mon Sep 17 00:00:00 2001
From: Son Dinh <dinhs@objectcomputing.com>
Date: Fri, 13 Sep 2024 10:07:47 -0500
Subject: [PATCH] Add comments for type names when generating complete type
 objects

---
 dds/idl/typeobject_generator.cpp | 39 +++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/dds/idl/typeobject_generator.cpp b/dds/idl/typeobject_generator.cpp
index 7bec3b2912..1ed4d5ca7a 100644
--- a/dds/idl/typeobject_generator.cpp
+++ b/dds/idl/typeobject_generator.cpp
@@ -542,6 +542,42 @@ void dump_bytes(const OpenDDS::XTypes::TypeObject& to)
   }
 }
 
+std::string get_type_name(const OpenDDS::XTypes::CompleteTypeObject& cto)
+{
+  switch (cto.kind) {
+  case OpenDDS::XTypes::TK_ALIAS:
+    return cto.alias_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_ANNOTATION:
+    return cto.annotation_type.header.annotation_name;
+  case OpenDDS::XTypes::TK_STRUCTURE:
+    return cto.struct_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_UNION:
+    return cto.union_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_BITSET:
+    return cto.bitset_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_SEQUENCE:
+    {
+      const OPENDDS_OPTIONAL_NS::optional<OpenDDS::XTypes::CompleteTypeDetail>& detail =
+        cto.sequence_type.header.detail;
+      return detail.has_value() ? detail->type_name : "anonymous sequence";
+    }
+  case OpenDDS::XTypes::TK_ARRAY:
+    return cto.array_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_MAP:
+    {
+      const OPENDDS_OPTIONAL_NS::optional<OpenDDS::XTypes::CompleteTypeDetail>& detail =
+        cto.map_type.header.detail;
+      return detail.has_value() ? detail->type_name : "anonymous map";
+    }
+  case OpenDDS::XTypes::TK_ENUM:
+    return cto.enumerated_type.header.detail.type_name;
+  case OpenDDS::XTypes::TK_BITMASK:
+    return cto.bitmask_type.header.detail.type_name;
+  default:
+    return "unknown type";
+  }
+}
+
 }
 
 void
@@ -645,7 +681,8 @@ typeobject_generator::gen_epilogue()
     idx = 0;
     for (OpenDDS::XTypes::TypeMap::const_iterator pos = complete_type_map_.begin();
          pos != complete_type_map_.end(); ++pos, ++idx) {
-      be_global->impl_ << "  tm[" << pos->first << "] = OPENDDS_IDL_FILE_SPECIFIC(complete_to, " << idx << ")();\n";
+      be_global->impl_ << "  tm[" << pos->first << "] = OPENDDS_IDL_FILE_SPECIFIC(complete_to, " <<
+        idx << ")(); // " << get_type_name(pos->second.complete) << "\n";
     }
 
     be_global->impl_ <<