Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ROS2NodeBuilder #32

Merged
merged 79 commits into from
Dec 3, 2024
Merged

Create ROS2NodeBuilder #32

merged 79 commits into from
Dec 3, 2024

Conversation

ds58
Copy link
Collaborator

@ds58 ds58 commented Nov 21, 2024

No description provided.

TomaszTB
TomaszTB reviewed Nov 21, 2024
View reviewed changes
Copy link

@TomaszTB TomaszTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's looking good so far

ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Outdated Show resolved Hide resolved
ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Show resolved Hide resolved
ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Outdated Show resolved Hide resolved
@ds58 ds58 changed the title [WIP] Create ROS2NodeBuilder Create ROS2NodeBuilder Dec 2, 2024
@ds58 ds58 marked this pull request as ready for review December 2, 2024 22:08
@ds58 ds58 requested review from calvertdw and TomaszTB December 2, 2024 22:08
TomaszTB
TomaszTB approved these changes Dec 2, 2024
View reviewed changes
Copy link

@TomaszTB TomaszTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking over a few things, but looks good!

ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Show resolved Hide resolved
ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Show resolved Hide resolved
ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Outdated Show resolved Hide resolved
ros2-library/src/test/java/us/ihmc/ros2/ROS2NodeBuilderTest.java Outdated Show resolved Hide resolved
ros2-library/src/main/java/us/ihmc/ros2/ROS2NodeBuilder.java Outdated Show resolved Hide resolved
ros2-library/src/test/java/us/ihmc/ros2/example/NonRealtimeROS2TalkerExample.java Show resolved Hide resolved
@ds58 ds58 merged commit f61521f into develop Dec 3, 2024
3 checks passed
@ds58 ds58 deleted the ros2nodebuilder branch December 3, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvertdw calvertdw calvertdw approved these changes

@TomaszTB TomaszTB TomaszTB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds58 @calvertdw @TomaszTB