Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Revisit present_agg_severity argument in agg #57

Open
chacalle opened this issue Dec 10, 2020 · 0 comments
Open

FEATURE: Revisit present_agg_severity argument in agg #57

chacalle opened this issue Dec 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@chacalle
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

These are the current options for present_agg_severity

#' **`present_agg_severity`** (`agg` only):
#'
#' Check for requested aggregates in `mapping` that are already present
#' 1. `stop`: throw error (this is the default).
#' 2. `warning` or `message`: throw warning/message, drop aggregates and continue
#' with aggregation.
#' 3. `none`: don't throw error or warning, drop aggregates and continue with
#' aggregation.
#' 4. `skip`: skip this check and add to the values already present for the
#' aggregates.

For 2/3 we are considering whether there should also be the option to preserve the original aggregate values rather than only the option to drop and re-aggregate.

Describe the solution you'd like
Add the option to either drop/re-aggregate or preserve the original aggregate.

If not easy to add both options, then default to preserving the existing aggregate.

Additional context
Originally brought up here https://github.com/ihmeuw-demographics/hierarchyUtils/pull/54/files#r538626632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant