Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build in Platformio, getTemperature is missing in cpp #27

Open
ZzubbuzZ opened this issue Nov 12, 2020 · 3 comments
Open

Can't build in Platformio, getTemperature is missing in cpp #27

ZzubbuzZ opened this issue Nov 12, 2020 · 3 comments

Comments

@ZzubbuzZ
Copy link

I download the master version of your lib to my project (I'am using platformio 5.0.1), I'm just updating an existing project that used OpenTherm::getTemperature().
The signature OpenTherm::getTemperature is present in your headers (l153), but not in your cpp...??

I fix it by adding this :

float OpenTherm::getTemperature(unsigned long response) {
	float temperature = isValidResponse(response) ? getFloat(response) : 0;
	return temperature;
}
@warnerthuis
Copy link

Is a fix coming for this error?

@ihormelnyk
Copy link
Owner

getTemperature is obsolete and should be removed
use getFloat function to parse response

@Chupaka
Copy link
Contributor

Chupaka commented Apr 1, 2021

908d43d fixed this, so the issue should be closed, I believe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants