Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about bloom_filter test in SSTableTest #4

Open
AcKing-Sam opened this issue Jul 28, 2024 · 2 comments
Open

Question about bloom_filter test in SSTableTest #4

AcKing-Sam opened this issue Jul 28, 2024 · 2 comments

Comments

@AcKing-Sam
Copy link

Hi, I have a question about the bloom_filter test in SSTableTest.

The test inserted 1e5 keys and tested 5e6 uninserted keys, but it failed on my local machine. Is it related to the computing power of my local CPU?
For example, I changed it to insert 5e4 keys and 2e5 uninserted keys, and it passed.

Thanks!

@yfzcsc
Copy link
Collaborator

yfzcsc commented Sep 21, 2024

Hello, sorry for my late response, the time limits of tests are determined by measuring the execution time on our course server, so it defintely related to your hardware configuration. If you just want to check the correctness, and you ensure that there are no errors on the time complexity, you can change the time limit.
I am very happy to see someone else to do this project.
Also, if you have any idea to improve the testing method, or the documents, please feel free to make comments.

@AcKing-Sam
Copy link
Author

@yfzcsc Thank you for the response! This project is awesome and I appreciate it for all your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants