Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flake8 to verison 7.1.1 #203

Open
glenrobson opened this issue Nov 23, 2024 · 1 comment
Open

Upgrade flake8 to verison 7.1.1 #203

glenrobson opened this issue Nov 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@glenrobson
Copy link
Contributor

glenrobson commented Nov 23, 2024

Decisions will have to be made on new checks and if we want to implement them or ignore them. Example issue:

./iiif_prezi3/helpers/add_label.py:20:20: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/helpers/add_label.py:31:20: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/helpers/auto_fields.py:123:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/helpers/auto_fields.py:125:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/helpers/make_range.py:14:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/helpers/make_range.py:19:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/loader.py:9:23: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/loader.py:11:44: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/loader.py:36:8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/loader.py:39:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  ./iiif_prezi3/loader.py:47:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
@glenrobson glenrobson added the bug Something isn't working label Nov 23, 2024
@glenrobson glenrobson changed the title E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance() Upgrade flake8 to verison 7.1.1 Nov 23, 2024
@glenrobson
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant