Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderedHash#insert_before and #insert_after are not used #54

Open
jcoyne opened this issue Apr 29, 2016 · 4 comments
Open

OrderedHash#insert_before and #insert_after are not used #54

jcoyne opened this issue Apr 29, 2016 · 4 comments
Labels

Comments

@jcoyne
Copy link
Collaborator

jcoyne commented Apr 29, 2016

They are only referenced by specs. Do we need them?

@jpstroop
Copy link

I added them because the IIIF spec implies a certain order for the keys, and make it easier to keep keys in a preferred order.

@jcoyne
Copy link
Collaborator Author

jcoyne commented Apr 29, 2016

Who is the consumer?

@jcoyne
Copy link
Collaborator Author

jcoyne commented Apr 29, 2016

If order is very important, I wonder if we wouldn't be better off modeling this as a list of tuples instead of a Hash.

@jpstroop
Copy link

That's where I started, actually, and then found myself writing a lot of methods I knew I could get from OrderedHash, but I'm open to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants