Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test issue #1 #1

Open
ikevin127 opened this issue Jan 28, 2024 · 53 comments
Open

Test issue #1 #1

ikevin127 opened this issue Jan 28, 2024 · 53 comments
Labels
Help Wanted Extra attention is needed Test

Comments

@ikevin127
Copy link
Owner

No description provided.

@ikevin127 ikevin127 added the Help Wanted Extra attention is needed label Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 28, 2024
@ikevin127
Copy link
Owner Author

ikevin127 commented Jan 28, 2024

Edited by proposal-police: This proposal was added at 2024-01-28 18:50:50 UTC.

Proposal
Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

But due to the fact that the input container has styles.textInputMultilineContainer which is paddingTop: 23, and the container inherits the GenericPressable's cursor.pointer styles because:

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

on this line there's no accesibilityRole or role passed down to the GenericPressable therefore we get the cursor.pointer and we see the pointer cursor.

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

To do this, within BaseTextInput we have to pass down the role prop to the PressableWithoutFeedback. This will make it such that the inherited cursor will be default instead of pointer.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Repository owner deleted a comment from proposal-police bot Jan 28, 2024
@ikevin127
Copy link
Owner Author

Proposal

What is the problem ?

Some problem.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

@ikevin127 Your proposal will be dismissed because you did not follow the proposal template.

Repository owner deleted a comment from proposal-police bot Jan 28, 2024
Repository owner deleted a comment from proposal-police bot Jan 29, 2024
Repository owner deleted a comment from proposal-police bot Jan 29, 2024
Repository owner deleted a comment from proposal-police bot Jan 29, 2024
Repository owner deleted a comment from proposal-police bot Jan 29, 2024
Repository owner deleted a comment from github-actions bot Jun 22, 2024
@ikevin127
Copy link
Owner Author

ikevin127 commented Jun 22, 2024

Edited by proposal-police: This proposal was edited at 2024-06-22 22:28:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

But due to the fact that the input container has styles.textInputMultilineContainer which is paddingTop: 23, and the container inherits the GenericPressable's cursor.pointer styles because:

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

on this line there's no accesibilityRole or role passed down to the GenericPressable therefore we get the cursor.pointer and we see the pointer cursor.

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

To do this, within BaseTextInput we have to pass down the role prop to the PressableWithoutFeedback. This will make it such that the inherited cursor will be default instead of pointer.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Copy link

@ikevin127 Your proposal will be dismissed because you did not follow the proposal template.

@ikevin127
Copy link
Owner Author

ikevin127 commented Jun 28, 2024

Edited by proposal-police: This proposal was edited at 2024-06-28 23:33:02 UTC.

Proposal

What is the problem ?

Some problem.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

@ikevin127 Your proposal will be dismissed because you did not follow the proposal template.

Repository owner deleted a comment from github-actions bot Jul 9, 2024
@ikevin127
Copy link
Owner Author

Proposal

What is the problem ?

Testing updated assistant proposal enforcement message.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

github-actions bot commented Jul 9, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

Copy link

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

But due to the fact that the input container has styles.textInputMultilineContainer which is paddingTop: 23, and the container inherits the GenericPressable's cursor.pointer styles because:

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

on this line there's no accesibilityRole or role passed down to the GenericPressable therefore we get the cursor.pointer and we see the pointer cursor.

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

To do this, within BaseTextInput we have to pass down the role prop to the PressableWithoutFeedback. This will make it such that the inherited cursor will be default instead of pointer.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

@ikevin127
Copy link
Owner Author

Proposal

What is the problem ?

Testing updated assistant proposal enforcement message.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

ikevin127 commented Aug 1, 2024

Edited by proposal-police: This proposal was edited at 2024-08-15 23:18:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

But due to the fact that the input container has styles.textInputMultilineContainer which is paddingTop: 23, and the container inherits the GenericPressable's cursor.pointer styles because:

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

on this line there's no accesibilityRole or role passed down to the GenericPressable therefore we get the cursor.pointer and we see the pointer cursor.

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

To do this, within BaseTextInput we have to pass down the role prop to the PressableWithoutFeedback. This will make it such that the inherited cursor will be default instead of pointer.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

@ikevin127
Copy link
Owner Author

ikevin127 commented Aug 15, 2024

Edited by proposal-police: This proposal was edited at 2024-08-15 23:27:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Copy link

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

ikevin127 commented Sep 22, 2024

Edited by proposal-police: This proposal was edited at 2024-09-22 03:51:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Copy link

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

ikevin127 commented Oct 2, 2024

Edited by proposal-police: This proposal was edited at 2024-10-02 22:24:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

ikevin127 commented Oct 2, 2024

Edited by proposal-police: This proposal was edited at 2024-10-02 22:27:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

@ikevin127
Copy link
Owner Author

ikevin127 commented Oct 2, 2024

Edited by proposal-police: This proposal was edited at 2024-10-02 22:27:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

@ikevin127
Copy link
Owner Author

ikevin127 commented Oct 2, 2024

Edited by proposal-police: This proposal was edited at 2024-10-02 22:27:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue
Hand cursor is displayed when hovering over the task description placeholder.

What is the root cause of that problem?
https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/TextInput/BaseTextInput/index.tsx#L320

We're using cursor: pointer on the task description label.

https://github.com/Expensify/App/blob/ac94dc545a322de63375107e34e1ab31c26eaffe/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L74

What changes do you think we should make in order to solve the problem?
We should change the style to cursor: default.

What alternative solutions did you explore? (Optional)
We can also do this by adding styles.cursorDefault within BaseTextInput's wrapper where the paddingTop: 23 is passed.

Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

2 similar comments
Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

Proposal

What is the problem ?

Testing updated assistant proposal enforcement message.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

@ikevin127
Copy link
Owner Author

Proposal

What is the problem ?

Testing updated assistant proposal enforcement message.

What is the root cause ?

Everything.

Solution ?

Test solution.

Copy link

github-actions bot commented Oct 2, 2024

@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal comment using the proposal template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed Test
Projects
None yet
Development

No branches or pull requests

2 participants