Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default name of idempotency header key #46

Open
hartmark opened this issue Mar 3, 2023 · 2 comments
Open

Default name of idempotency header key #46

hartmark opened this issue Mar 3, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hartmark
Copy link

hartmark commented Mar 3, 2023

According to the rfc draft the proposed name would be Idempotency-Key so we should rename the default.

https://datatracker.ietf.org/doc/draft-ietf-httpapi-idempotency-key-header/

Comments?

@ikyriak
Copy link
Owner

ikyriak commented May 13, 2023

Hello @hartmark
As far as I can see, the Idempotency-Key header name is still an Internet-Draft. We can consider it as a work in progress. In addition, this will be a breaking change in the library.

However, I am unsure how the library is used and if the majority use the Idempotency-Key header name.

cc: @dimmy-timmy, @kvuong, @bernardiego, @MohamadTahir, @Rast1234, @lvzhuye, @RichardGreen-IS2, @apchenjun, @william-keller, @fjsosa

@ikyriak ikyriak added the enhancement New feature or request label May 13, 2023
@ikyriak ikyriak self-assigned this May 13, 2023
@Rast1234
Copy link

i'm not an active user of your implementation, our impl uses custom header name because that standard is still a draft and we decided to ignore its existence until it's finished 😆
sticking to standards is good, but i'd contact someone responsible for that rfc to see if they are going to change header name. to avoid changing defaults again, you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants