Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to configure controllers via IdempotencyOptions #68

Closed
Jevvry opened this issue Mar 7, 2024 · 1 comment · Fixed by #69 or #70
Closed

Possibility to configure controllers via IdempotencyOptions #68

Jevvry opened this issue Mar 7, 2024 · 1 comment · Fixed by #69 or #70

Comments

@Jevvry
Copy link
Contributor

Jevvry commented Mar 7, 2024

There are projects that contain a large number of controllers. Because of this, important idempotency settings such as ExpiresInMilliseconds, DistributedLockTimeoutMilli are dispersed throughout the project. And this increases the likelihood of a configuration error.

It seems to me that it would be convenient to add the ability to configure controllers via DI registration of IdempotencyOptions and optionally use these settings in the IdempotentAttribute.

@ikyriak
Copy link
Owner

ikyriak commented Mar 24, 2024

Hello @Jevvry,
Thank you for your time and implementation in configuring controllers via IdempotencyOptions. This is an excellent idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants