🐛TypedResults always returning 200 OK with no body

[michael-wolfenden]

Given the following code:

async Task Main()
{
  var builder = WebApplication.CreateBuilder();
  builder.Services.AddIdempotentMinimalAPI(new IdempotencyOptions());
  builder.Services.AddIdempotentAPIUsingDistributedCache();
  builder.Services.AddDistributedMemoryCache();

  var app = builder.Build();

  app
    .MapPost("/todoitems/{id}", Results<Ok<Todo>, NotFound>(int id) => TypedResults.Ok(new Todo("My Todo")))
    .AddEndpointFilter<IdempotentAPIEndpointFilter>();

  app.Run();
}

Without the .AddEndpointFilter<IdempotentAPIEndpointFilter>();

POST http://localhost:64913/todoitems/1 HTTP/1.1
User-Agent: vscode-restclient
IdempotencyKey: 9fc0e0e5-a152-468a-beeb-680df8e87bc1
accept-encoding: gzip, deflate

HTTP/1.1 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Tue, 22 Oct 2024 23:48:58 GMT
Server: Kestrel
Transfer-Encoding: chunked

{
  "name": "My Todo"
}

With the .AddEndpointFilter<IdempotentAPIEndpointFilter>();

POST http://localhost:65077/todoitems/1 HTTP/1.1
User-Agent: vscode-restclient
IdempotencyKey: c79454c9-48e1-498c-8927-7bf8c5f1cf53
accept-encoding: gzip, deflate

HTTP/1.1 200 OK
Connection: close
Content-Type: text/plain; charset=utf-8
Date: Tue, 22 Oct 2024 23:49:49 GMT
Server: Kestrel
Transfer-Encoding: chunked

You also receive a 200 OK if the typed result returns a NotFound

  app
    .MapPost("/todoitems/{id}", Results<Ok<Todo>, NotFound>(int id) => TypedResults.NotFound())
    .AddEndpointFilter<IdempotentAPIEndpointFilter>();

[ikyriak]

Hello @michael-wolfenden,

Thank you for taking the time to report this issue 🙏 .
I will let you know when I have a fix in place.

[ikyriak]

Hello @michael-wolfenden,

Unfortunately, to support TypedResults will require redesigning the library, including breaking changes. This is an excellent opportunity for me to start it 😄 . However, it will need some time to be completed.