feat: Add iOS, macOS, and BSD native support #251
Conversation
brian6932
force-pushed
the
feat/ios-macos-bsd-support
branch
from
a5290a4 to
bffe2be
Compare
brian6932
force-pushed
the
feat/ios-macos-bsd-support
branch
from
bffe2be to
0c8bc90
Compare
|
Are you running apt-fast on one of those systems? |
Yes. |
| @@ -247,7 +254,11 @@ _create_lock() | |||
| # unlock and remove the lock file | |||
| _remove_lock() | |||
| { | |||
| flock -u "$LCK_FD" 2>/dev/null | |||
| if [ $KERNEL = 'Linux' ]; then | |||
There was a problem hiding this comment.
| if [ $KERNEL = 'Linux' ]; then | |
| if [[ "$KERNEL" == 'Linux' ]]; then |
There was a problem hiding this comment.
The suggestion's not POSIX compliant afaict.
There was a problem hiding this comment.
apt-fast uses some non-posix functionality (already isn´t posix compliant).
There was a problem hiding this comment.
Weird, but I don't really understand how this provides any benefits (I don't use bash and other posix shells normally/willingly).
Co-authored-by: Dominique Lasserre <[email protected]>
| @@ -247,7 +254,11 @@ _create_lock() | |||
| # unlock and remove the lock file | |||
| _remove_lock() | |||
| { | |||
| flock -u "$LCK_FD" 2>/dev/null | |||
| if [ $KERNEL = 'Linux' ]; then | |||
There was a problem hiding this comment.
The suggestion's not POSIX compliant afaict.
|
The only thing I'll mention's that root users can delete the lockfile when |
I used this on a rootfully jailbroken iOS device. There are some differences with the paths in the documentation for Darwin based kernels that I had to resolve, but this at least makes it work.