Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Compat with Glow Banners #27

Open
Ultimushadow opened this issue Jul 27, 2023 · 0 comments
Open

[Feature]: Compat with Glow Banners #27

Ultimushadow opened this issue Jul 27, 2023 · 0 comments
Assignees
Labels
status: workshop This issue or pull request is under consideration type: enhancement New feature or request

Comments

@Ultimushadow
Copy link

What is the new feature or improvement?

Hey there, I was wondering if you would be interested in adding compat for Glow Banners. I think this would require a separate item to be registered with the same code, but with an emissive texture, but I'm not actually sure. With the latest update of Bed Spreads (6.2.0), when putting on a glow banner it doesn't break the texture or anything and even has the Glowing tag indication when hovering over the item, but of course the bed itself does not have an emissive texture, which is what the compat would add. While it may not seem obvious what this adds to the mod, playing with lighting (or in this case, emission) is a very unique tool in Minecraft and I think that it expands the usage of decorative items like this well beyond just adding some extra patterns. Let me know what you think!

@Ultimushadow Ultimushadow added status: triage This issue or pull request is awaiting review type: enhancement New feature or request labels Jul 27, 2023
@TheIllusiveC4 TheIllusiveC4 added status: workshop This issue or pull request is under consideration and removed status: triage This issue or pull request is awaiting review labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: workshop This issue or pull request is under consideration type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants